[RFAv3 2/5] Add [-q] [-t TYPEREGEXP] [NAMEREGEXP] args to info [args|functions|locals|variables]

Pedro Alves palves@redhat.com
Mon Oct 22 14:16:00 GMT 2018


On 09/23/2018 10:42 PM, Philippe Waroquiers wrote:

> @@ -2043,14 +2055,37 @@ do_print_variable_and_value (const char *print_name,
>    p->values_printed = 1;
>  }
>  
> +/* Prepares the regular expression REG from REGEXP.
> +   If REGEXP is NULL, it results in an empty regular expression.  */
> +static void

Space between comment and function.

> +prepare_reg (const char *regexp, gdb::optional<compiled_regex> *reg)
> +{

> @@ -2121,7 +2173,6 @@ iterate_over_block_arg_vars (const struct block *b,
>  	     symbol is double and the type of the LOC_LOCAL symbol is
>  	     float).  There are also LOC_ARG/LOC_REGISTER pairs which
>  	     are not combined in symbol-reading.  */
> -
>  	  sym2 = lookup_symbol_search_name (SYMBOL_SEARCH_NAME (sym),
>  					    b, VAR_DOMAIN).symbol;
>  	  (*cb) (SYMBOL_PRINT_NAME (sym), sym2, cb_data);

Spurious change?

Really no further comments here.  :-)

Thanks,
Pedro Alves



More information about the Gdb-patches mailing list