[RFC 1/8] Change wrap buffering to use a std::string

Tom Tromey tom@tromey.com
Thu Oct 18 22:16:00 GMT 2018


>>>>> "Tom" == Tom Tromey <tom@tromey.com> writes:

>>> To prevent this, change the wrap buffer to be a std::string and update
>>> the various uses.

Simon> This looks like a good change to me, independently of this series.  I think you
Simon> should push it right away.

Tom> FWIW I think this patch will have to change to accommodate Windows -- or
Tom> at least be totally obsoleted by the needed change.  My plan is to have
Tom> a vector holding strings with their styling.  This has to happen because
Tom> styling on Windows is done via an API, not via an escape sequence.

I think I'm going to change plans here, due to my desire to also
style source code in the TUI.

GNU Source Highlight and Pygments both have ANSI terminal escape back
ends.  And, I already have code that can parse ANSI escapes and turn
them into curses calls.

My new plan for handling Windows is to generalize this ANSI escape
parser and let it be specialized to emit console calls or whatever they
are.

Maybe I'll push this patch in independently after all... not sure yet.

Tom



More information about the Gdb-patches mailing list