[PATCH 3/6] Eliminate make_symbol_overload_list-related globals & cleanup

Simon Marchi simon.marchi@ericsson.com
Wed Oct 17 17:25:00 GMT 2018


On 2018-10-15 11:11 a.m., Pedro Alves wrote:
> This gets rid of a few globals and a cleanup.
> 
> make_symbol_overload_list & friends currently maintain a global
> open-coded vector.  Reimplement that with a std::vector, trickled down
> through the functions.  Rename a few functions from "make_" to "add_"
> for clarity.

LGTM, my only comment would be to avoid non-const passing by reference, as in
the previous patch.

Simon



More information about the Gdb-patches mailing list