[PATCH] Fix various tests to use -no-pie linker flag when needed

[Jan Vrany]

Hi, 

I'm sorry for a long delay, I've been very, very busy lately.
Hopefully I'd have more time for GDB now...


On Fri, 2018-09-07 at 23:18 +0100, Simon Marchi wrote:
> On 2018-09-07 21:43, Tom Tromey wrote:
> > > > > > > "Jan" == Jan Vrany <jan.vrany@fit.cvut.cz> writes:
> > 
> > Jan> Various test use test code written in i385 / x86_64 assembly that 
> > cannot
> > Jan> be used to create PIE executables. Therefore compilation of test 
> > programs
> > Jan> failed on systems where the compiler default is to create PIE 
> > executable.
> > 
> > Jan> To fix this, force -no-pie linker flag.
> > 
> > I guess you're on an OS that enables PIE by default?
> 
> I know recent-ish Ubuntus do that, I don't know if it's a patch specific 
> to that distro or if it's the default value in gcc that changed.

Neither I know. I'm using Debian Buster which seems to have -no-pie 
by default too. 

> 
> > These tests don't seem to be linux- or gcc-specific.
> > Do you know how universal -no-pie is?  My worry is that this would fix
> > the test for some people but break it for others.
> > 

No, I don't know how universal -no-pie is. From what I have understood
from Simon (https://sourceware.org/ml/gdb-patches/2018-08/msg00662.html),
out of the options available -no-pie is still the best bet. 

> > Tom
> 
> If needed, we could add a new option understood by gdb_compile that adds 
> the right flag to achieve the result of -no-pie.

Indeed we can. Tom, would that be OK with you? 

Best Jan