[PATCH 0/8] Add -Wshadow=local

[Pedro Alves]

On 10/03/2018 05:15 PM, Simon Marchi wrote:

> I looked at the code, it all LGTM.  As I said in my other message, I think
> it would be easy to miss subtle mistakes when reviewing, given the repetitive
> nature of the patch, but I don't really see a better/safer approach to do the
> change.  I think it will be a net positive.

I agree.  If this causes bugs not caught by the testsuite, I guess you
could say that the problem is that we're missing some tests.

I quickly skimmed the patches and it all looked reasonable to me too.

Thanks,
Pedro Alves