[PATCH 4/5] gdb/23712: Remove dw2_add_symbol_to_list
Tom Tromey
tom@tromey.com
Fri Nov 30 20:58:00 GMT 2018
>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:
Keith> Finally, we can remove dw2_add_symbol_to_list since the wrapper function
Keith> originally introduced to catch this multi-language scenario is no longer
Keith> needed. With multi-language dictionaries, we can now support adding
Keith> symbols of multiple languages, negating the need for the assertion
Keith> entirely.
Keith> This patch should now fix gdb/23712 (and symtab/23010). At least it will
Keith> if the NULL buildsym_compunit problem doesn't strike first (see gdb/23773).
Keith> gdb/ChangeLog:
Keith> PR gdb/23712
Keith> * dwarf2read.c (dw2_add_symbol_to_list): Remove.
Keith> (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
Thanks, this is ok.
Maybe the ChangeLog should mention symtab/23010?
Tom
More information about the Gdb-patches
mailing list