[RFC/PATCH] Fix dwarf2read.c:dwarf2_find_containing_comp_unit's binary search

Tom Tromey tom@tromey.com
Fri Nov 30 17:52:00 GMT 2018


>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:

Sergio> 	https://bugzilla.redhat.com/show_bug.cgi?id=1613614
Sergio> 	* dwarf2read.c (dwarf2_find_containing_comp_unit): Add
Sergio> 	'mid_cu->length' to '*cu_off' when checking if 'sect_off' is
Sergio> 	inside the CU.

Thanks for the extensive analysis.
I agree this is correct; please check this in.

It's weird that cu_off is a pointer in this code.
It seems like that local could be removed entirely.
But, no need to do that in this patch.

Tom



More information about the Gdb-patches mailing list