[PATCH 1/2] sim/opcodes: Allow use of out of tree cgen source directory
Simon Marchi
simon.marchi@polymtl.ca
Mon Nov 26 21:07:00 GMT 2018
On 2018-11-06 12:35, Andrew Burgess wrote:
> diff --git a/opcodes/configure.ac b/opcodes/configure.ac
> index 4c3698356b..9e48fedf9a 100644
> --- a/opcodes/configure.ac
> +++ b/opcodes/configure.ac
> @@ -109,11 +109,21 @@ AC_ARG_ENABLE(cgen-maint,
> yes) cgen_maint=yes ;;
> no) cgen_maint=no ;;
> *)
> - # argument is cgen install directory (not implemented yet).
> - # Having a `share' directory might be more appropriate for the .scm,
> - # .cpu, etc. files.
> + # Argument is a directory where cgen can be found. In some
> + # future world cgen could be installable, but right now this
> + # is not the case. Instead we assume the directory is a path
> + # to the cgen source tree.
> cgen_maint=yes
> - cgendir=${cgen_maint}/lib/cgen
> + if test -r ${enableval}/iformat.scm; then
> + # This looks like a cgen source tree.
> + cgendir=${enableval}
> + else
> + # This code would handle a cgen install. For now we assume
> + # 'lib', but this is really just a place holder. Maybe
> + # having a `share' directory might be more appropriate for
> + # the .scm, .cpu, etc. files.
> + cgendir=${enableval}/lib/cgen
> + fi
> ;;
> esac])dnl
> AM_CONDITIONAL(CGEN_MAINT, test x${cgen_maint} = xyes)
Just wondering, does the "else" part have any real-world use? Before
today, was there any reason to pass a path to --enable-cgen-maint ?
Simon
More information about the Gdb-patches
mailing list