>>>>> "Simon" == Simon Marchi <simon.marchi@ericsson.com> writes: >> + data->guesses.push_back (new_guess); Simon> I always prefer having a constructor and using Simon> data-> guesses.emplace_back (bytes, tdesc); Simon> since it makes it impossible to have uninitialized fields by mistake. I'm checking it in with this change. Tom