[PATCH][gdb/symtab] Fix language of duplicate static minimal symbol

Simon Marchi simon.marchi@polymtl.ca
Wed Nov 7 15:24:00 GMT 2018


On 2018-10-31 05:09, Tom de Vries wrote:
> I have a pre-commit script (for both gcc and gdb) that uses this 
> format,
> and puts ChangeLog hunks in the correct ChangeLog file ( more detail
> here: https://sourceware.org/ml/gdb-patches/2018-06/msg00351.html ).
> Sofar this format has been acceptable for maintainers.

Yes, as long as they end up in the right file it's fine.

The patch LGTM too.  Before, pushing could you just add a one liner 
description in your .exp file?  Something like:

# Test that when two symbols with the same linkage name are present in 
the
# executable, they both get assigned the right language.

Thanks,

Simon



More information about the Gdb-patches mailing list