[PATCH] gdb: Handle ICC's unexpected void return type

Tom Tromey tom@tromey.com
Tue Nov 6 18:11:00 GMT 2018


>>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:

Andrew> I encountered a binary compiled with Intel's C Compiler version
Andrew> 14.0.5.212, which seemed to contain some non-standard DWARF.
[...]

Andrew> A test confirms that the issue is fixed.

Thanks for this test.  It's very good to have these; in the past I think
some compiler workarounds have gone in without such tests, and then
later it is difficult to figure out whether changes keep gdb working.

Andrew> +	if (bits == 0 && producer_is_icc (cu)
Andrew> +	    && strcmp (name, "void") == 0)

I think NAME can be null here, so an additional check is needed to avoid
a potential crash.

Tom



More information about the Gdb-patches mailing list