[RFA] Remove a VEC from type.c
Tue May 29 17:58:00 GMT 2018
>>>>> "Simon" == Simon Marchi <firstname.lastname@example.org> writes:
>> +/* Compares type A to type B returns true if the represent the same
>> + type, false otherwise. */
Simon> Could you fix the "the" -> "they" typo at the same time? It wouldn't hurt to
Simon> improve the syntax as well, it reads a bit weird.
I fixed this.
Simon> Not really related to your patch, but I think we could reduce the number of
Simon> required comparisons/arithmetic operations by doing
Simon> if (s == NULL || t == NULL)
Simon> return s == t;
Simon> return strcmp (s, t) == 0;
I did this too. I went to look at the assembly but with the new,
shorter version, it is always inlined.
I'm going to check this in momentarily.
More information about the Gdb-patches