[PATCH 5/8] [PowerPC] Fix access to VSCR in linux targets

Pedro Franco de Carvalho pedromfc@linux.vnet.ibm.com
Thu May 17 21:25:00 GMT 2018


Ulrich Weigand <uweigand@de.ibm.com> writes:

> I'm wondering if we shouldn't have the common regcache_collect_regset
> routine zero out areas covered by REGCACHE_MAP_SKIP?  Then we wouldn't
> need this extra routine here.
>
>> -static const struct regset ppc32_linux_vrregset = {
>> -  &ppc32_linux_reg_offsets,
>> -  ppc_supply_vrregset,
>> -  ppc_collect_vrregset

I think this might affect the s390 target: in s390-linux-nat,
fill_gregset uses collect_regset on a buffer that has already been
filled through ptrace (PTRACE_PEEKUSR_AREA), which is then used to
extract pswm, so it relies on collect_regset not changing the buffer on
the skipped slots.



More information about the Gdb-patches mailing list