[PATCH 8/8] [PowerPC] Recognize isa205 in linux core files
Pedro Franco de Carvalho
pedromfc@linux.vnet.ibm.com
Wed May 16 23:32:00 GMT 2018
Ulrich Weigand <uweigand@de.ibm.com> writes:
> Maybe this routine should now be moved to ppc-linux-tdep.c ...
>
>> + CORE_ADDR hwcap = 0;
>> +
>> + target_auxv_search (target, AT_HWCAP, &hwcap);
>> +
>> + features.isa205 = ppc_linux_has_isa205 (hwcap);
>
> ... so it can be reused here?
>
> Otherwise this looks OK to me.
Should the routine take a struct target_ops * parameter, so that
core_read_description can pass its target (for calling
target_auxv_search)? In this case all the calls in ppc_linux_nat.c would
also have to be updated.
Thanks!
Pedro
More information about the Gdb-patches
mailing list