[PATCH 3/3] gdbserver/Windows: crash during connection establishment phase

Joel Brobecker brobecker@adacore.com
Fri May 4 18:58:00 GMT 2018


> > +#ifndef IN_PROCESS_AGENT
> > +#ifdef __x86_64__
> > +  static const char *expedite_regs_amd64[] = { "rbp", "rsp", "rip", NULL };
> > +  tdesc->expedite_regs = expedite_regs_amd64;
> > +#else /* __x86_64__ */
> > +  static const char *expedite_regs_i386[] = { "ebp", "esp", "eip", NULL };
> > +  tdesc->expedite_regs = expedite_regs_i386;
> > +#endif /* __x86_64__ */
> > +#endif
> 
> Won't all x86 ports have the same problem?  I.e., don't
> nto-x86-low.c:nto_x86_arch_setup and
> lynx-i386-low.c:lynx_i386_arch_setup need the same treatment?
> Should we put those arrays in some shared i386 file?

They probably would, but these are platforms I cannot test at
the moment, so I didn't want to take a risk and create a situation
for them. I'm quite happy to adjust the way you suggest.

-- 
Joel

PS: If you are surprised by me saying I can't test on LynxOS at
    the moment, it's because I don't have a C++ cross compiler
    for that platform. I'm still hoping that we might be able
    to build one, but it requires some work.



More information about the Gdb-patches mailing list