[PATCH] Eliminate target_ops::to_xclose

Pedro Alves palves@redhat.com
Thu May 3 00:00:00 GMT 2018


On 04/27/2018 04:24 PM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
> 
> Pedro> In the multi-target branch, I found no need for the target_close vs
> Pedro> target_xclose distinction.  Heap-allocated targets simply delete
> Pedro> themselves in their target_close implementation, while
> Pedro> singleton/static targets don't.
> 
> Pedro> The target_ops C++ification patches will add more commentary around
> Pedro> target_ops's destructor, but there's no destructor yet...
> 
> This looks good to me and it seems like the close/xclose distinction
> already doesn't really make sense anyway.
Thanks for taking a look Tom.  I've merged it.

Thanks,
Pedro Alves



More information about the Gdb-patches mailing list