[RFA 1/2] Remove cleanups from gdb_readline_wrapper
Tom Tromey
tom@tromey.com
Sun Mar 25 16:19:00 GMT 2018
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
Pedro> I think we can move these to the ctor too, and then all the fields
Pedro> of the structure can be made private. Something like the patch
Pedro> below. (Tested on x86-64 GNU/Linux.)
Seems like a good idea to me.
Pedro> While at it, since we're touching most of the structure, we might as
Pedro> well reindent it to have open { at column 0. (Not done below to keep
Pedro> the patch readable.)
I added this and did the reindentation.
Also I removed the "explicit" from the constructor.
Tom
More information about the Gdb-patches
mailing list