[PATCH] Make "info proc cmdline" show args on GNU/Linux

[Simon Marchi]

On 2018-03-22 14:45, Andreas Arnez wrote:
> On Thu, Mar 22 2018, Simon Marchi wrote:
> 
>> On 2018-03-22 05:04, Andreas Arnez wrote:
>>>>> 
>>>>> +# Set command line arguments to be verified later with "info proc
>>>>> +# cmdline".  However, if we're using a stub, then "set args" would
>>>>> not
>>>>> +# have any effect, so then just skip this.
>>>>> +
>>>>> +set cmdline ""
>>>>> +if { ! [target_info exists use_gdb_stub] } {
>>>> 
>>>> The use_gdb_stub proc from lib/gdb.exp should be used instead (its
>>>> comment
>>>> explains why).
>>> 
>>> Ah, OK.  There are still some occurrences of "target_info exists
>>> use_gdb_stub" in the test suite.  Should these be replaced as well?
>> 
>> Yes, they probably should.
> 
> All right.  How about the patch below?
> 
> --
> Andreas
> 
> -- >8 --
> Subject: [PATCH] Testsuite: fully migrate to use_gdb_stub convenience 
> func
> 
> In the GDB test suite, there are still multiple invocations of
> "target_info exists use_gdb_stub".  However, the recommended way of
> checking for use_gdb_stub is to call the convenience function of the 
> same
> name.
> 
> Replace these occurrences and just call "use_gdb_stub" instead.

Awesome, thanks!

LGTM.

Simon