[PATCH 1/3] S390: Enable re-attaching with native-extended-gdbserver

Simon Marchi simon.marchi@ericsson.com
Wed Mar 21 19:39:00 GMT 2018


I am just looking through this to have an idea of what's happening
and found one nit:

> +/* Determine the word size for the given PID, in bytes.  */
> +
> +#ifdef __s390x__
> +static int
> +s390_get_wordsize (int pid)
> +{
> +  errno = 0;
> +  PTRACE_XFER_TYPE pswm = ptrace (PTRACE_PEEKUSER, pid,
> +				  (PTRACE_TYPE_ARG3) 0,
> +				  (PTRACE_TYPE_ARG4) 0);
> +  if (errno != 0) {
> +    warning (_("Couldn't determine word size, assuming 64-bit.\n"));
> +    return 8;
> +  }

GNU-style curly braces.

Simon



More information about the Gdb-patches mailing list