Breakage on builder Fedora-x86_64-native-extended-gdbserver-m64, revision 4ee89e903de920496a69c01df70db13a70a2a0be

[gdb-buildbot@sergiodj.net]

Unfortunately it seems that there is a breakage on GDB.

Commit title: 'Replace the linear search in find_pc_sect_line with a binary search.'
Revision: 4ee89e903de920496a69c01df70db13a70a2a0be

You can find more details below:

+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+

Buildslave:
	fedora-x86-64-3

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-native-extended-gdbserver-m64/builds/9124>

Commit(s) tested:
	4ee89e903de920496a69c01df70db13a70a2a0be

Author(s) (in the same order as the commits):
	Stephen Roberts <stephen.roberts@arm.com>

Subject:
	Replace the linear search in find_pc_sect_line with a binary search.

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-x86_64-native-extended-gdbserver-m64/4e/4ee89e903de920496a69c01df70db13a70a2a0be/>

*** Failed to compiled GDB.  ***
============================

+++ The full log is too big to be posted here.
+++ These are the last 100 lines of it.

In file included from ../../binutils-gdb/gdb/inferior.h:48:0,
                 from ../../binutils-gdb/gdb/infrun.c:26:
../../binutils-gdb/gdb/progspace.h:284:31: warning: *((void*)(& maybe_restore_inferior)+32).scoped_restore_current_program_space::m_saved_pspace may be used uninitialized in this function [-Wmaybe-uninitialized]
   { set_current_program_space (m_saved_pspace); }
     ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~
../../binutils-gdb/gdb/infrun.c:927:6: note: *((void*)(& maybe_restore_inferior)+32).scoped_restore_current_program_space::m_saved_pspace was declared here
      maybe_restore_inferior;
      ^~~~~~~~~~~~~~~~~~~~~~
  CXX    location.o
  CXX    m2-lang.o
  CXX    m2-typeprint.o
  CXX    m2-valprint.o
  CXX    macrocmd.o
  CXX    macroexp.o
  CXX    macroscope.o
  CXX    macrotab.o
  CXX    main.o
  CXX    maint.o
  CXX    mdebugread.o
  CXX    mem-break.o
  CXX    memattr.o
  CXX    memory-map.o
  CXX    memrange.o
  CXX    minidebug.o
  CXX    minsyms.o
  CXX    mipsread.o
  CXX    namespace.o
  CXX    objc-lang.o
  CXX    objfiles.o
  CXX    observable.o
  CXX    opencl-lang.o
  CXX    osabi.o
  CXX    osdata.o
  CXX    p-lang.o
  CXX    p-typeprint.o
  CXX    p-valprint.o
  CXX    parse.o
  CXX    printcmd.o
  CXX    probe.o
  CXX    producer.o
  CXX    progspace.o
  CXX    progspace-and-thread.o
  CXX    prologue-value.o
  CXX    psymtab.o
  CXX    record.o
  CXX    record-btrace.o
  CXX    record-full.o
  CXX    regcache.o
In file included from ../../binutils-gdb/gdb/exceptions.h:23:0,
                 from ../../binutils-gdb/gdb/utils.h:24,
                 from ../../binutils-gdb/gdb/defs.h:676,
                 from ../../binutils-gdb/gdb/record-btrace.c:22:
../../binutils-gdb/gdb/ui-out.h: In function void btrace_insn_history(ui_out*, const btrace_thread_info*, const btrace_insn_iterator*, const btrace_insn_iterator*, gdb_disassembly_flags):
../../binutils-gdb/gdb/ui-out.h:197:18: warning: asm_list.ui_out_emit_type<(ui_out_type)1>::m_uiout may be used uninitialized in this function [-Wmaybe-uninitialized]
     m_uiout->end (Type);
     ~~~~~~~~~~~~~^~~~~~
../../binutils-gdb/gdb/record-btrace.c:658:35: note: asm_list.ui_out_emit_type<(ui_out_type)1>::m_uiout was declared here
   gdb::optional<ui_out_emit_list> asm_list;
                                   ^~~~~~~~
  CXX    regcache-dump.o
  CXX    reggroups.o
  CXX    registry.o
  CXX    remote.o
  CXX    remote-fileio.o
  CXX    remote-notif.o
  CXX    reverse.o
  CXX    rust-lang.o
  CXX    sentinel-frame.o
  CXX    ser-event.o
  CXX    serial.o
  CXX    skip.o
  CXX    solib.o
  CXX    solib-target.o
  CXX    source.o
  CXX    stabsread.o
  CXX    stack.o
  CXX    std-regs.o
  CXX    symfile.o
  CXX    symfile-debug.o
  CXX    symmisc.o
  CXX    symtab.o
  CXX    target.o
  CXX    target-dcache.o
../../binutils-gdb/gdb/symtab.c: In function symtab_and_line find_pc_sect_line(CORE_ADDR, obj_section*, int):
../../binutils-gdb/gdb/symtab.c:3224:5: error: this if clause does not guard... [-Werror=misleading-indentation]
     if (item != first)
     ^~
../../binutils-gdb/gdb/symtab.c:3237:7: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the if
       if (prev && prev->line && (!best || prev->pc > best->pc))
       ^~
  CXX    target-descriptions.o
  CXX    target-memory.o
cc1plus: all warnings being treated as errors
make[2]: *** [Makefile:1607: symtab.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory '/home/gdb-buildbot/fedora-x86-64-3/fedora-x86-64-native-extended-gdbserver/build/gdb'
make[1]: Leaving directory '/home/gdb-buildbot/fedora-x86-64-3/fedora-x86-64-native-extended-gdbserver/build'
make[1]: *** [Makefile:8793: all-gdb] Error 2
make: *** [Makefile:850: all] Error 2
============================