[PATCH] Add xml_escape_text_append and use it

[Simon Marchi]

On 2018-03-02 22:23, Simon Marchi wrote:
> [This patch should go on top of "linux_qxfer_libraries_svr4: Use
>  std::string", I should have sent them together as a series.]
> 
> I noticed that linux_qxfer_libraries_svr4 used xml_escape_text, which
> returns an std::string.  That string is then copied into a larger
> buffer.  It would be more efficient if we had a version of
> xml_escape_text which appended to an existing string instead of
> returning a new one.  This is what this patch does.
> 
> I manually verified that the output of linux_qxfer_libraries_svr4 
> didn't
> change before/after the patch.
> 
> gdb/ChangeLog:
> 
> 	* common/xml-utils.c (xml_escape_text): Move code to...
> 	(xml_escape_text_append): ... this new function.
> 	* common/xml-utils.h (xml_escape_text_append): New declaration.
> 	* unittests/xml-utils-selftests.c (test_xml_escape_text_append):
> 	New function.
> 	(_initialize_xml_utils): register test_xml_escape_text_append as
> 	a selftest.
> 
> gdb/gdbserver/ChangeLog:
> 
> 	* linux-low.c (linux_qxfer_libraries_svr4): Use
> 	xml_escape_text_append.

I pushed this patch.

Simon