[PATCH 2/3] Add a new debug knob for the FreeBSD native target.

Pedro Alves palves@redhat.com
Fri Mar 2 20:19:00 GMT 2018


LGTM, but one small question below.

On 02/28/2018 01:46 AM, John Baldwin wrote:
> @@ -765,6 +765,7 @@ fbsd_xfer_partial (struct target_ops *ops, enum target_object object,
>  
>  #ifdef PT_LWPINFO
>  static int debug_fbsd_lwp;
> +static int debug_fbsd_nat;

Should this be guarded by PT_LWPINFO?  Wouldn't you want to
enable fbsd-nat debugging on FreeBSD systems without PT_LWPINFO?

(Hmm, does GDB actually build today if PT_LWPINFO is not defined?)

Thanks,
Pedro Alves



More information about the Gdb-patches mailing list