[PATCH] Conditionally include "<windows.h>" on common/pathstuff.c (and unbreak build on mingw*)
Simon Marchi
simon.marchi@polymtl.ca
Fri Mar 2 15:15:00 GMT 2018
On 2018-03-02 08:32, Eli Zaretskii wrote:
>> From: Sergio Durigan Junior <sergiodj@redhat.com>
>> Cc: Simon Marchi <simon.marchi@ericsson.com>, Pedro Alves
>> <palves@redhat.com>, Joel Brobecker
>> <brobecker@adacore.com>, Christophe Lyon
>> <christophe.lyon@linaro.org>, Sergio Durigan Junior
>> <sergiodj@redhat.com>
>> Date: Thu, 1 Mar 2018 15:20:05 -0500
>>
>> +#ifdef USE_WIN32API
>> +#include <windows.h>
>> +#endif
>
> Isn't USE_WIN32API specific to gdbserver? If so, perhaps it's better
> to use __MINGW32__ or _WIN32 instead?
I see it defined in both gdb and gdbserver:
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=blob;f=gdb/configure.ac;h=698fc7b83456f8c5a63ae0050dc8ec65069290f7;hb=HEAD#l1908
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=blob;f=gdb/gdbserver/configure.ac;h=99801681ff47ee8dcd9ad2e5ae282dcd113c83e4;hb=HEAD#l281
Simon
More information about the Gdb-patches
mailing list