[PATCH] Improve gcore shell quoting and portability

Georg Sauthoff mail@georg.so
Thu Mar 1 19:48:00 GMT 2018


On Sun, Feb 25, 2018 at 05:41:40PM -0500, Simon Marchi wrote:

Hello,

[..]
> >  	# `</dev/null' to avoid touching interactive terminal if it is
> >  	# available but not accessible as GDB would get stopped on SIGTTIN.
> > -	$binary_path/@GDB_TRANSFORM_NAME@ </dev/null --nx --batch \
> > +	"$binary_path"/@GDB_TRANSFORM_NAME@ </dev/null --nx --batch \

> To be pedantic, I guess we would have to quote the whole path, since
> GDB_TRANSFORM_NAME could contain some spaces.  It's not very likely, I agree,
> but it's also easy to change.
 
> If you are fine with the suggestions above, I could fix them and push the resulting
> patch, is that ok with you?

yes, I'm fine with all your suggestion.

I'm also a fan of the `#!/usr/bin/env someinterpreter` construct.

Thus, please go ahead.

Best regards
Georg



More information about the Gdb-patches mailing list