[RFA] Remove a VEC from py-unwind.c
Simon Marchi
simon.marchi@ericsson.com
Wed Jun 27 20:21:00 GMT 2018
On 2018-06-27 02:44 PM, Andrew Burgess wrote:
> * Tom Tromey <tom@tromey.com> [2018-06-05 10:04:50 -0600]:
>
>> This removes a use of VEC from py-unwind.c, replacing it wit
>> std::vector. It also changes saved_regs to hold a gdbpy_ref<>,
>> simplifying the memory management.
>>
>> Tested against gdb.python on x86-64 Fedora 26.
>>
>> gdb/ChangeLog
>> 2018-06-05 Tom Tromey <tom@tromey.com>
>>
>> * python/py-unwind.c (unwind_info_object) <saved_regs>: Now a
>> std::vector.
>> (unwind_infopy_str, pyuw_create_unwind_info)
>> (unwind_infopy_add_saved_register, pyuw_sniffer)
>> (unwind_infopy_dealloc, unwind_infopy_add_saved_register):
>> Update.
>> (struct saved_reg): Add constructor.
>> <value>: Now a gdbpy_ref<>.
>
> FWIW I took a look through this patch and it looks good.
>
> Thanks,
> Andrew
LGTM too, thanks Andrew for taking a look.
Simon
More information about the Gdb-patches
mailing list