[PATCH v4] GDB PR tdep/8282: MIPS: Wire in `set disassembler-options'
Maciej W. Rozycki
macro@mips.com
Thu Jun 21 18:29:00 GMT 2018
Hi Simon,
> This patch looks good from the GDB side (with one nit in the test below), but
> somebody from binutils would need to review the bits in opcodes/include.
Yes, that's why I requested it separately and posted to both mailing
lists.
> > +# Verify ABI overrides.
> > +mips_disassemble_test bar "move\t\\\$2,\\\$8" "disassemble ABI (numeric)"
> > +gdb_test "set disassembler-options"
> > +gdb_test "set mips abi o32"
> > +mips_disassemble_test bar "move\tv0,t0" "disassemble ABI (o32)"
> > +gdb_test "set mips abi n32"
> > +mips_disassemble_test bar "move\tv0,a4" "disassemble ABI (n32)"
> > +gdb_test "set mips abi n64"
> > +mips_disassemble_test bar "move\tv0,a4" "disassemble ABI (n64)"
>
> Avoid parenthesis at the end of test names:
>
> https://sourceware.org/gdb/wiki/GDBTestcaseCookbook#Do_not_use_.22tail_parentheses.22_on_test_messages
Thanks for the pointer. Although it makes sense to me at first glance
that's quite a recent change to a long-established practice. Perhaps it
could have been avoided by coding the regression analysis tools referred
more carefully, but I won't be questioning the decision at this point.
The wiki does not indicate a suggested replacement however and I would
rather avoid creating a mess where individual tests would use different
approaches. Offhand I'd be inclined to use brackets, either square or
angled. What has been the new practice then?
Maciej
More information about the Gdb-patches
mailing list