[PATCH] Support large registers in regcache transfer_regset
Simon Marchi
simark@simark.ca
Tue Jun 19 21:12:00 GMT 2018
On 2018-06-19 11:46, Alan Hayward wrote:
> Ah, ok. If doing that, then itâd make sense to update
> regcache_map_entry to use
> unsigned ints for count and size.
>
> struct regcache_map_entry
> {
> int count;
> int regno;
> int size;
> };
>
> At that point it probably makes sense to repost the patch as v2 in
> smaller pieces?
If you end up doing this (I did not really dig much to see if it works),
then yes it might make sense to have a preparatory patch that changes
some types to be unsigned. As always, one logical change per patch is
appreciated and is much easier to review.
If you're going to send a proper v2, I'll wait for this one to look at
the new changes you sent as part of the "updated" v1.
Simon
More information about the Gdb-patches
mailing list