[RFA 00/10] Remove standalone ptid functions

Tom Tromey tom@tromey.com
Thu Jun 14 15:42:00 GMT 2018


>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

Pedro> I'm just not so sure about eliminating pid_to_ptid.  I'd ran into uses
Pedro> of that where I had second thoughts on whether replacing it with
Pedro> a ptid_t ctor call is really a good idea.  What I thought was,
Pedro> that when you're reading the code, a pid_to_ptid call more clearly shows
Pedro> that want to build a process-wide (sometimes a filter) ptid as opposed
Pedro> to a single thread ptid.  It also helps with grepping, if you'd like
Pedro> to find such spots.  But it's not a big deal, and I can certainly live
Pedro> with it.

It's easy enough to drop it out of the series if you would prefer that,
or to rename it to something like ptid_t::from_pid.  Let me know.

Tom



More information about the Gdb-patches mailing list