[RFA 00/10] Remove standalone ptid functions

Simon Marchi simon.marchi@polymtl.ca
Thu Jun 14 02:04:00 GMT 2018


On 2018-06-13 19:22, Joel Brobecker wrote:
>> This series removes the remaining standalone ptid functions in favor
>> of using methods on ptid_t.
>> 
>> These patches were largely created by running a script.
> 
> Looks like a very nice cleanup. I scanned through some of the patches,
> but not being the C++ expert in the group, I only did it out of
> curiosity for now. It looks fairly mechanical, as hinted by the fact
> that Tom said it was created by running a script.
> 
> Anyone against the idea behind the change itself? Otherwise, I'd be
> inclined to allow Tom to self-review on that one.
> 
> Thanks Tom!

Yay, thanks Tom, I did not have the courage to do that!  I was just 
waiting for Pedro to eliminate ptid_t completely with his multi-target 
work :).

I sampled a few files, and it LGTM.  I also built the cross-compiled 
Linux configurations I have, and it went fine.  If there's a compilation 
failure resulting from this, it should be very easy to fix.

Simon



More information about the Gdb-patches mailing list