[PATCH v2 2/4] Make add-symbol-file's address argument optional

Eli Zaretskii eliz@gnu.org
Mon Jun 11 15:25:00 GMT 2018


> From: Petr Tesarik <ptesarik@suse.cz>
> Cc: Petr Tesarik <ptesarik@suse.cz>,	Jeff Mahoney <jeffm@suse.com>
> Date: Mon, 11 Jun 2018 14:08:33 +0200
> 
> The (first) .text section must be always specified as the second
> non-option argument.  The documentation states that GDB cannot
> figure out this address by itself.  This is true if the object file
> was indeed relocated, but it is also confusing, because all other
> sections can be omitted and will use the address provided by BFD.
> 
> gdb/ChangeLog:
> 2018-06-11  Petr Tesarik  <ptesarik@suse.com>
> 
> 	* symfile.c (add_symbol_file_command, _initialize_symfile): Do not
> 	require the second argument.  If omitted, load sections at the
> 	addresses specified in the file.
> 
> gdb/doc/ChangeLog:
> 2018-06-11  Petr Tesarik  <ptesarik@suse.com>
> 
> 	* gdb.texinfo (Files): The address argument for "add-symbol-file"
> 	is no longer mandatory.
> 
> gdb/testsuite/ChangeLog:
> 2018-06-11  Petr Tesarik  <ptesarik@suse.com>
> 
> 	* gdb.base/relocate.exp: Test add-symbol-file behavior when the
> 	address argument is omitted.

I have a feeling I already reviewed and approved this, but in case I
didn't, I approve it now.

Thanks.



More information about the Gdb-patches mailing list