[RFA] Change build_address_symbolic to return std::string

Tom Tromey tom@tromey.com
Wed Jun 6 22:38:00 GMT 2018


>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:

Keith> Did someone looks this over already?

Nope.

>> +extern int build_address_symbolic (struct gdbarch *,
>> +				   CORE_ADDR addr,
>> +				   int do_demangle,
>> +				   std::string *name,
>> +				   int *offset,
>> +				   std::string *filename,
>> +				   int *line,
>> +				   int *unmapped);

Keith> Since you're moving the declaration here, could you please copy
Keith> the comment from the definition here, too, while you're at it,
Keith> replacing it with the usual "See XYZ.h"? [Warning: IANAM]

Good idea, I've made this change locally.

Tom



More information about the Gdb-patches mailing list