[RFA 2/6] Change representation of psymbol to flush out accessors
Simon Marchi
simon.marchi@polymtl.ca
Tue Jun 5 19:49:00 GMT 2018
On 2018-06-04 14:11, Tom Tromey wrote:
>>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:
>
>>> + h = hash_continue (&psymbol->pginfo.name, sizeof
>>> (psymbol->pginfo.name), h);
>
> Keith> I realize this is just a renaming of the existing code, but
> since
> Keith> there is an accessor for `name', I think it better to use it (in
> Keith> case someone ends up grepping for this).
> [...]
> Keith> Same here for PSYMBOL_LANGUAGE and PSYMBOL_LINKAGE_NAME?
>
> I've made these changes locally.
>
> Tom
I wanted for a while to convert all these macros to static inline
functions, it just hasn't been high on the todo list. Since you're
adding new code, would you mind making them static inline functions
instead of macros (if you agree with the idea, of course)?
Simon
More information about the Gdb-patches
mailing list