[PATCH v2] linux: Add maintenance commands to test libthread_db

Pedro Alves palves@redhat.com
Tue Jun 5 16:31:00 GMT 2018


Hi Gary,

On 05/23/2018 06:32 PM, Gary Benson wrote:

> Ok to commit?

This looks good to me too, except one thing.  I think
you end up with duplicated test messages:

  https://sourceware.org/gdb/wiki/GDBTestcaseCookbook#Make_sure_test_messages_are_unique

I suggestwrapping the several phases of the testcase in with_test_prefix
or proc_with_prefix.  Something like:

# Manual check with NPTL fully operational.

with_test_prefix "manual fully op" {
   ...
}

# Automated check with NPTL uninitialized.

with_test_prefix "automated uninitialized" {
   ...
}

etc.

OK with me with that change.

Thanks,
Pedro Alves



More information about the Gdb-patches mailing list