[RFA 4/6] Introduce accessors for psymtab high and low fields

Keith Seitz keiths@redhat.com
Fri Jun 1 20:48:00 GMT 2018


On 05/03/2018 03:36 PM, Tom Tromey wrote:
> I did this conversion by renaming the fields.  I didn't rename the
> fields back afterward, thinking that on the off chance that someone
> has a patch touching this area, then a merge would helpfully break
> their compile.

/me likey
;-)

Just a little request:

> 	* dbxread.c (read_dbx_symtab, end_psymtab, read_ofile_symtab):
> 	Update.
> 	* mdebugread.c (parse_lines, parse_partial_symbols)
> 	(psymtab_to_symtab_1): Update.

These files still mention ->textlow and/or ->texthigh. Could you please adjust the comments accordingly?

Otherwise, LGTM (but IANAM).

[And for the record, this patch (and the next) will also show "regressions" because of patch #3.]

Keith



More information about the Gdb-patches mailing list