[PATCH v2] Do not classify C struct members as a filename
Leszek Swirski via gdb-patches
gdb-patches@sourceware.org
Thu Jan 25 16:39:00 GMT 2018
> This change makes sense (and thanks for updating that comment as well),
> but I wonder whether this changes the behavior in some case. Elsewhere
> in lex_one_token there is a check of saw_structop:
>
> else if (saw_structop)
> return COMPLETE;
>
> Previously this return could only be taken if parse_completion was set,
> but now I think it could be taken in other situations.
>
> So, I suspect "parse_completion &&" should be stuck in there.
Nice catch, thanks! I looked at the other users of saw_structop and
last_was_structop, and it looks like this is the only location that
needs an update. PTAL at v4.
More information about the Gdb-patches
mailing list