[PATCH] Move arch/tdesc.h to common/common-tdesc.h

[Yao Qi]

Alan Hayward <Alan.Hayward@arm.com> writes:

> Tested by build for x86, ppc and aarch64, using both make 4.1 and make 3.81.
> Ran unittests for x86. Checked that my later patch series can apply on top.

Looks this patch breaks the GDBserver build on aarch64-linux,

g++ -x c++ -std=gnu++11 -g -O2    -I. -I../../../binutils-gdb/gdb/gdbserver -I../../../binutils-gdb/gdb/gdbserver/../common -I../../../binutils-gdb/gdb/gdbserver/../regformats -I../../../binutils-gdb/gdb/gdbserver/.. -I../../../binutils-gdb/gdb/gdbserver/../../include -I../../../binutils-gdb/gdb/gdbserver/../gnulib/import -Ibuild-gnulib-gdbserver/import  -Wall -Wpointer-arith -Wno-unused -Wunused-value -Wunused-function -Wno-switch -Wno-char-subscripts -Wempty-body -Wunused-but-set-parameter -Wunused-but-set-variable -Wno-sign-compare -Wno-narrowing -Wno-error=maybe-uninitialized -Wformat-nonliteral -Werror -DGDBSERVER -c -o arch/aarch64.o -MT arch/aarch64.o -MMD -MP -MF arch/.deps/aarch64.Tpo ../../../binutils-gdb/gdb/gdbserver/../arch/aarch64.c
In file included from ../../../binutils-gdb/gdb/gdbserver/../arch/aarch64.h:23:0,
                 from ../../../binutils-gdb/gdb/gdbserver/../arch/aarch64.c:19:
../../../binutils-gdb/gdb/gdbserver/tdesc.h:57:8: error: ‘char_ptr’ has not been declared
   VEC (char_ptr) *features = NULL;
        ^
../../../binutils-gdb/gdb/gdbserver/tdesc.h:57:16: error: ISO C++ forbids declaration of ‘VEC’ with no type [-fpermissive]
   VEC (char_ptr) *features = NULL;
                ^
../../../binutils-gdb/gdb/gdbserver/tdesc.h:57:16: error: expected ‘;’ at end of member declaration
../../../binutils-gdb/gdb/gdbserver/tdesc.h: In destructor ‘target_desc::~target_desc()’:
../../../binutils-gdb/gdb/gdbserver/tdesc.h:82:30: error: ‘char_ptr’ was not declared in this scope
     for (i = 0; VEC_iterate (char_ptr, features, i, f); i++)
                              ^
../../../binutils-gdb/gdb/gdbserver/tdesc.h:82:54: error: ‘VEC_iterate’ was not declared in this scope
     for (i = 0; VEC_iterate (char_ptr, features, i, f); i++)
                                                      ^
../../../binutils-gdb/gdb/gdbserver/tdesc.h:84:15: error: ‘char_ptr’ was not declared in this scope
     VEC_free (char_ptr, features);
               ^
../../../binutils-gdb/gdb/gdbserver/tdesc.h:84:33: error: ‘VEC_free’ was not declared in this scope
     VEC_free (char_ptr, features);
                                 ^
make[4]: *** [arch/aarch64.o] Error 1

-- 
Yao (齐尧)