[RFA v2] (Ada) Fix frame argument printing when using auto language mode

Joel Brobecker brobecker@adacore.com
Fri Feb 23 09:37:00 GMT 2018


> Patch is good to me, some comments below,
> 
> > +extern const struct language_defn ada_language_defn;
> > +
> >  static int print_field_values (struct type *, const gdb_byte *,
> >  			       int,
> >  			       struct ui_file *, int,
> > @@ -1208,7 +1210,7 @@ ada_val_print (struct type *type,
> >      {
> >        ada_val_print_1 (type, embedded_offset, address,
> >  		       stream, recurse, val, options,
> > -		       current_language);
> > +		       &ada_language_defn);
> 
> or we can use "language_def (language_ada)", so that we don't need to
> declare ada_language_defn above.

I would prefer this as well - to remain consistent with what we do
elsewhere.

-- 
Joel



More information about the Gdb-patches mailing list