Remove a few more cleanups: solib and openp

[Pedro Alves]

On 02/13/2018 11:39 PM, Tom Tromey wrote:
> This series removes a few cleanups by using unique_xmalloc_ptr.  This
> also helps clarify the ownership rules of a few APIs.  This series
> also includes a couple of minor (non-cleanup-related) code clarity
> improvements in related areas: moving some declarations out of defs.h,
> and a constification.
> 
> Regression tested by the buildbot.

Nice!  LGTM.  Please push.

I was wondering whether you'd write patch #1 the other day you
touched some of that code.  :-)  On that patch, you may want to remove
the  "The returned pathname is malloc'ed and must be freed by the caller."
remarks from the intro comments of (at least) solib_find_1,
exec_file_find and solib_find (in solib.c).

Thanks,
Pedro Alves