[PATCH 00/12] Remove some ALL_* iteration macros

[Simon Marchi]

On 2018-12-24 3:54 p.m., Tom Tromey wrote:
>>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
> 
> Joel> As for the downside, I don't consider re-indentation a downside
> Joel> other than it makes review a bit more painful. The two-nested
> Joel> loop didn't seem like they were making the code less readable.
> Joel> Did you have any other concerns with that?
> 
> Nope.
> 
> Joel> I admit I was scanning the last few patches much faster than the first
> Joel> few ones, but they seem fairly mechanical to me, so I think the risk
> Joel> is low.
> 
> I think I will have to redo much of the series to account for that
> version of gcc that Simon sometimes uses -- the one that requires ranged
> for loops to use the "struct" keyword.  I probably can't really test
> that change but I'll make a best effort at it in order to reduce the
> amount of work he has to do.

Hehe.  Looking back at those patches, it's with gcc 6.3.0.  Those are cross-compilers
I built with crosstool-ng 1.22:

$ ~/x-tools/aarch64-rpi3-linux-gnueabi/bin/aarch64-rpi3-linux-gnueabi-gcc --version
aarch64-rpi3-linux-gnueabi-gcc (crosstool-NG crosstool-ng-1.22.0-677-ga3dd55b9) 6.3.0

I see crosstool-ng 1.23 has been released, but it still uses gcc 6.3.0.  And it looks like
the gcc version used in current Debian stable (codename stretch) is also 6.3.0:

  https://packages.debian.org/stretch/gcc

I'll give a try to this patchset (and take a quick look at the same time).

Simon