[RFC/PATCH] Fix dwarf2read.c:dwarf2_find_containing_comp_unit's binary search
Sergio Durigan Junior
sergiodj@redhat.com
Tue Dec 4 16:50:00 GMT 2018
On Tuesday, December 04 2018, Keith Seitz wrote:
> On 11/30/18 10:05 AM, Sergio Durigan Junior wrote:
>> On Friday, November 30 2018, Tom Tromey wrote:
>>
>>>>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:
>>>
>>> Sergio> https://bugzilla.redhat.com/show_bug.cgi?id=1613614
>>> Sergio> * dwarf2read.c (dwarf2_find_containing_comp_unit): Add
>>> Sergio> 'mid_cu->length' to '*cu_off' when checking if 'sect_off' is
>>> Sergio> inside the CU.
>>>
>>> Thanks for the extensive analysis.
>>> I agree this is correct; please check this in.
>>
>> Thanks for the quick review. This has been pushed:
>>
>> 81fbbaf96216ed88973a069e4ed25379d7421ec8
>>
>
> Is this needed for 8.2 branch?
Yep, I'd say so. This seems like a simple patch to be backported to
8.2, but I'll wait for a global maintainer to give the green light so
that I can create a proper bug.
Thanks,
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/
More information about the Gdb-patches
mailing list