[PATCH 5/5] RISC-V: Add configure support riscv*-linux*.
Tom Tromey
tom@tromey.com
Wed Aug 8 17:30:00 GMT 2018
>>>>> "Jim" == Jim Wilson <jimw@sifive.com> writes:
Jim> * Makefile.in (ALLDEPFILES): Add riscv-linux-nat.c, riscv-linux-tdep.c.
This doesn't mention the ALL_TARGET_OBS change.
Jim> * NEWS: Mention new GNU/Linux RISC-V target.
Eli should review this bit.
Jim> * configure.host: Add riscv*-*-linux*.
Jim> * configure.nat: Add riscv*.
Jim> * configure.tgt: Add riscv*-*-linux*.
These parts are ok.
Jim> diff --git a/gdb/Makefile.in b/gdb/Makefile.in
Jim> index 8c744d70c0..280b3b1283 100644
Jim> --- a/gdb/Makefile.in
Jim> +++ b/gdb/Makefile.in
Jim> @@ -752,6 +752,8 @@ ALL_TARGET_OBS = \
Jim> ppc-sysv-tdep.o \
Jim> ppc64-tdep.o \
Jim> ravenscar-thread.o \
Jim> + riscv-linux-nat.o \
Jim> + riscv-linux-tdep.o \
Jim> riscv-tdep.o \
Jim> rl78-tdep.o \
Jim> rs6000-aix-tdep.o \
I think only the tdep file should be listed here.
ALL_TARGET_OBS is used when --enable-targets=all is given.
In this case, we would not want the riscv-linux-nat.o object to be
linked in, since we're not necessarily building on linux.
Is riscv a 64-bit architecture? (I don't know.) If so, gdb still
splits 64-bit targets into a separate variable, I think in case one is
building on a 32-bit machine without a 64-bit integer type (or maybe if
you didn't want to use the extra memory to inflate a bunch of type
sizes, not sure). In this case you'd want to add the tdep file to
ALL_64_TARGET_OBS instead.
I wonder if this 32/64 bit thing is needed any more.
Tom
More information about the Gdb-patches
mailing list