[RFA] Change rs6000_ptrace_ldinfo to return a byte_vector

[Simon Marchi]

On 2018-04-01 12:25 PM, Tom Tromey wrote:
> This changes rs6000_ptrace_ldinfo to return a byte_vector.  I think
> this points out an existing double-free in
> rs6000_xfer_shared_libraries.

Eh, indeed.

> Tested by the buildbot.
> 
> gdb/ChangeLog
> 2018-03-31  Tom Tromey  <tom@tromey.com>
> 
> 	* rs6000-nat.c (rs6000_ptrace_ldinfo): Return a byte_vector.
> 	(rs6000_xfer_shared_libraries): Update.
> ---
>  gdb/ChangeLog    |  5 +++++
>  gdb/rs6000-nat.c | 28 ++++++++++------------------
>  2 files changed, 15 insertions(+), 18 deletions(-)
> 
> diff --git a/gdb/rs6000-nat.c b/gdb/rs6000-nat.c
> index 4f05cd6b6a..fbc9b52623 100644
> --- a/gdb/rs6000-nat.c
> +++ b/gdb/rs6000-nat.c
> @@ -587,21 +587,21 @@ rs6000_create_inferior (struct target_ops * ops, const char *exec_file,
>  
>     The returned value must be deallocated after use.  */

This comment here could be removed.

Otherwise, LGTM.

Simon