[RFA 08/12] Remove cleanup from complaints.c

Pedro Alves palves@redhat.com
Thu Sep 28 22:09:00 GMT 2017


On 09/28/2017 08:50 PM, Tom Tromey wrote:

> -	  char *msg;
> -	  struct cleanup *cleanups;
> -	  msg = xstrvprintf (fmt, args);
> -	  cleanups = make_cleanup (xfree, msg);
> +	  std::string msg (string_vprintf (fmt, args));

Please use copy-init.  Otherwise OK.

Thanks,
Pedro Alves



More information about the Gdb-patches mailing list