On 09/28/2017 08:50 PM, Tom Tromey wrote: > - char *msg; > - struct cleanup *cleanups; > - msg = xstrvprintf (fmt, args); > - cleanups = make_cleanup (xfree, msg); > + std::string msg (string_vprintf (fmt, args)); Please use copy-init. Otherwise OK. Thanks, Pedro Alves