[RFA 02/12] Remove cleanup from display_gdb_prompt

Pedro Alves palves@redhat.com
Thu Sep 28 21:56:00 GMT 2017


Looks good, but ...

On 09/28/2017 08:50 PM, Tom Tromey wrote:

>  /* Return the top level prompt, as specified by "set prompt", possibly
> @@ -428,7 +422,7 @@ display_gdb_prompt (const char *new_prompt)
>     with the prompt prefix and suffix (annotations).  The caller is
>     responsible for freeing the returned string.  */

... please remove that last sentence from the comment above.

>  
> -static char *
> +static std::string
>  top_level_prompt (void)
>  {

Thanks,
Pedro Alves



More information about the Gdb-patches mailing list