[PATCH V2] dwarf2read: move producers help functions to a dwarf specific file

Pedro Alves palves@redhat.com
Tue Sep 26 15:44:00 GMT 2017


On 09/25/2017 03:51 PM, Walfred Tedeschi wrote:
> This patch add new files for the dwarf producer checks.

Not for the dwarf producer checks, but for the producer parsing.
Please update.

> +#include "defs.h"
> +#include "producer.h"
> +#include "utils.h"
> +
> +#if defined GDB_SELF_TEST
> +#include "selftest.h"
> +#endif

This "selftest.h" inclusion doesn't belong in this patch.
Please move it to the other patch, which actually adds the
selftests.

Otherwise OK.  Please push (this patch) once fixed.

Thanks,
Pedro Alves



More information about the Gdb-patches mailing list