[PATCH] icc: allow code path for newer versions of icc.

Pedro Alves palves@redhat.com
Thu Sep 21 12:03:00 GMT 2017


On 09/21/2017 12:27 PM, Tedeschi, Walfred wrote:
> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-owner@sourceware.org] On Behalf Of Pedro Alves

>> But I went ahead and took a quick look.  I have to say that don't care for the "dwarf2utils" name much BTW.  My issue with "utils.h|c" is that >"utils" is a kitchen sync name; almost anything can be called an "utility".  And "dwarf2utils" has almost the same issue, in my view.  Note that I >had suggested producers.h/c without a "dwarf" qualification because the producers string is exposed in generic code, through >symtab.h:compunit_symtab etc.
>> (even though the producers info is currently only sourced from DWARF info).

> My concern with the name was to create a file that could be used for more things, but not much more.
> Do you consider a better approach to have a specialized file, having only the producers on it?

Yes.

Thanks,
Pedro Alves



More information about the Gdb-patches mailing list