[PATCH 3/4] Introduce gdb_chdir
Pedro Alves
palves@redhat.com
Thu Sep 14 15:23:00 GMT 2017
On 09/14/2017 04:14 PM, Sergio Durigan Junior wrote:
> On Wednesday, September 13 2017, Pedro Alves wrote:
>
>> On 09/12/2017 05:23 AM, Sergio Durigan Junior wrote:
>>> +/* Perform path expansion (i.e., tilde expansion) on DIR, and return
>>> + the full path. */
>>> +
>>> +static std::string
>>> +expand_path (const char *dir)
>>
>> Since this is particularly about tilde expansion,
>> and a replacement for "tilde_expand", did you consider calling
>> it gdb_tilde_expand and using it throughout? If this were an
>> extern function, I'd press for having "tilde" in its name,
>> to make the call sites a bit more obvious.
>
> Sure, no problem in renaming it. Just to clarify: when you mean "use it
> throughout", are saying that this should be used to replace readline's
> "tilde_expand" elsewhere on GDB?
Yes, and no. Yes, by 'throughout' I meant elsewhere in GDB.
But no, I'm not _saying_ it should. I'm really asking if you
considered/thought about that.
I think what I'm really wondering is whether tilde_expand
and this new function behave exactly the same, or whether
glob behaves a little different in some cases. If it behaves
differently [and the differences are benign), then I get to
wonder whether we should use it throughout so that different
commands don't behave differently.
E.g., does "cd *" behave the same before/after ? Or does
'glob' expand '*' while tilde_expand didn't?
Thanks,
Pedro Alves
More information about the Gdb-patches
mailing list