[PATCH 3/3] Add tests for loop_break and loop_continue commands

Simon Marchi simon.marchi@polymtl.ca
Mon Sep 4 17:16:00 GMT 2017


On 2017-09-04 14:36, Pedro Alves wrote:
> On 09/02/2017 10:36 PM, Simon Marchi wrote:
>> I grepped the testsuite for loop_break and loop_continue and didn't 
>> find
>> anything, so I wrote some simple tests for those.
>> 
>> gdb/testsuite/ChangeLog:
>> 
>> 	* gdb.base/commands.exp: Call the new procedures.
>> 	(loop_break_test, loop_continue_test): New procedures.
> 
> LGTM, please push, and thanks for doing this.
> 
> I do wonder whether we handle loop_break/loop_continue in nested
> loops correctly though, since the tests don't seem to
> exercise that.
> 
> Thanks,
> Pedro Alves

Ah good point.  I am pushing this one, and I'll work on another patch to 
test this.

Thanks,

Simon



More information about the Gdb-patches mailing list