Opinion about -Wtautological-compare
Yao Qi
qiyaoltc@gmail.com
Mon Oct 30 09:35:00 GMT 2017
On Sat, Oct 28, 2017 at 4:24 AM, Simon Marchi <simon.marchi@ericsson.com> wrote:
> Personally, I think the warning is useful and can reveal bugs, so I'd like to keep
> it. I lean towards 2 or 3, because they help convey the idea that we check if the
> value is within a range. If you are following with the architecture manual on the
> side, it will probably show the same range (0-3) for those bits, so it helps if the
> code does the same.
>
My vote is 3. PR 22188.
--
Yao (齐尧)
More information about the Gdb-patches
mailing list