[PATCH] Simplify regcache::xfer_part

Simon Marchi simon.marchi@polymtl.ca
Mon Oct 16 15:58:00 GMT 2017


On 2017-10-16 09:18, Yao Qi wrote:
> Since xfer_part is already a class method, and only
> {raw,cooked}_{read,write} are passed to it.  We can remove these two
> arguments, but add a bool argument is_raw, indicating raw registers or
> cooked registers are accessed.
> 
> Regression tested on x86_64-linux, both native and gdbserver.
> 
> gdb:
> 
> 2017-10-16  Yao Qi  <yao.qi@linaro.org>
> 
> 	* regcache.c (regcache::xfer_part): Remove parameters read and
> 	write, add parameter is_raw.  All callers are updated.

LGTM, it's a bit simpler to understand this way I think.



More information about the Gdb-patches mailing list